Skip to content
This repository has been archived by the owner on Apr 26, 2019. It is now read-only.

[Fix #330] Do not handle claims for issues that have been merged already #340

Merged
merged 3 commits into from
Mar 15, 2018

Conversation

vitvly
Copy link

@vitvly vitvly commented Mar 1, 2018

Fixes #330

Check for commit_sha on linked issue when processing incoming pull request. If it's already set, do not create a new PR for it.

This also removes an unneeded call to GitHub API that fetches issue data for a PR. We don't need this, as issue data are stored in the DB.

@churik
Copy link
Member

churik commented Mar 15, 2018

Environments

  • Ethereum wallet used: MetaMask
  • Browser: Chrome
  • Operating System: macOS High Sierra 10.13.3

Tested functionality

  • 1 bounty (1 PR is merged, 2 PR is opened after 1 is merged) > no more new claims after merging ;
  • 1 bounty (several PRs are merged) > 1 merged PR is winner
  • 1 bounty (several PRs, only one is merged) > merged PR is winner

@churik churik merged commit 9d9ebef into develop Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants