Skip to content

Refactored version of BlobSidecar/DataColumnSidecar quarantine. #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tersec merged 17 commits into from
May 13, 2025
Merged

Refactored version of BlobSidecar/DataColumnSidecar quarantine. #7100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4f89a2a
Initial commit.
cheatfate Apr 23, 2025
e844c41
Address review comments.
cheatfate Apr 28, 2025
9f9758e
Address compilation issue, lets call it untyped sandwich.
cheatfate Apr 28, 2025
af32ae4
Fix - return empty sequence when block does not hold any blobs/columns.
cheatfate Apr 28, 2025
ebc0d7a
Add test for previous case.
cheatfate Apr 29, 2025
ea7fc59
Add Blob/Column quarantine test to test suite.
cheatfate Apr 29, 2025
30dfeb5
Update AllTests.
cheatfate Apr 29, 2025
f30a8f5
Fix put(openArray) check if len(sidecars) fits in quarantine, add tes…
cheatfate May 5, 2025
94644af
Improve checkResponseSanity().
cheatfate May 5, 2025
c9b960a
Eliminate slot handling facilities.
cheatfate May 12, 2025
1c91d9d
Address review comments.
cheatfate May 12, 2025
3fc3bc5
Fix compilation warning introduced.
cheatfate May 12, 2025
982e62a
Fix put() duplicate items making counters wrong.
cheatfate May 13, 2025
cda8613
Remove asSeq(), add optimized iterator with tests.
cheatfate May 13, 2025
995ebf4
Remove duplication checks in Request Manager getMissingBlobs() loop.
cheatfate May 13, 2025
07ce212
Update AllTests.
cheatfate May 13, 2025
d7d6b53
Address review comments.
cheatfate May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions AllTests-mainnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,16 @@ AllTests-mainnet
+ Electra toSignedBlindedBeaconBlock OK
+ Fulu toSignedBlindedBeaconBlock OK
```
## BlobQuarantine data structure test suite [Preset: mainnet]
```diff
+ overfill protection test OK
+ popSidecars()/hasSidecars() return []/true on block without blobs OK
+ pruneAfterFinalization() test OK
+ put() duplicate items should not affect counters OK
+ put()/fetchMissingSidecars/remove test OK
+ put()/hasSidecar(index, slot, proposer_index)/remove() test OK
+ put(sidecar)/put([sidecars])/hasSidecars/popSidecars/remove() test OK
```
## Block pool altair processing [Preset: mainnet]
```diff
+ Invalid signatures [Preset: mainnet] OK
Expand Down Expand Up @@ -146,6 +156,19 @@ AllTests-mainnet
+ atSlot sanity OK
+ parent sanity OK
```
## ColumnQuarantine data structure test suite [Preset: mainnet]
```diff
+ ColumnMap test OK
+ overfill protection test OK
+ popSidecars()/hasSidecars() return []/true on block without columns OK
+ pruneAfterFinalization() test OK
+ put() duplicate items should not affect counters OK
+ put()/fetchMissingSidecars/remove test [node] OK
+ put()/fetchMissingSidecars/remove test [supernode] OK
+ put()/hasSidecar(index, slot, proposer_index)/remove() test OK
+ put(sidecar)/put([sidecars])/hasSidecars/popSidecars/remove() [node] test OK
+ put(sidecar)/put([sidecars])/hasSidecars/popSidecars/remove() [supernode] test OK
```
## Combined scenarios [Beacon Node] [Preset: mainnet]
```diff
+ ImportKeystores should not be blocked by fee recipient setting [Beacon Node] [Preset: main OK
Expand Down
Loading
Loading