Refactored version of BlobSidecar/DataColumnSidecar quarantine.#7100
Merged
Refactored version of BlobSidecar/DataColumnSidecar quarantine.#7100
Conversation
53f9b8d to
a6fa107
Compare
tersec
reviewed
Apr 23, 2025
tersec
reviewed
Apr 24, 2025
96a5b97 to
70f0ecc
Compare
55cdd77 to
20f7c09
Compare
tersec
reviewed
May 9, 2025
tersec
reviewed
May 9, 2025
tersec
reviewed
May 9, 2025
20f7c09 to
9f66085
Compare
Add DataColumn tests.
…t for this issue. Add compile time checks for ColumnMap.
Address review comment about `hasSidecar` possible issues. Update tests.
58a71f1 to
c9b960a
Compare
Add pruning of blob quarantine and tests.
Contributor
|
looks like maybe |
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
Contributor
|
982e62a adds tests but doesn't update the test summaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this new version of BlobQuarantine/DataColumnQuarantine number of issues being solved.
slotor byrootonly.popBlobs: Opt[T].