Skip to content

fix: string -> int for ports.discovery and listener #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jangko merged 4 commits into from
Jul 2, 2025
Merged

fix: string -> int for ports.discovery and listener #3438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e6cd79
fix: string -> int for ports.discovery and listener
barnabasbusa Jul 1, 2025
845199e
Merge branch 'fix-imports' into fix-ports-json-types
barnabasbusa Jul 1, 2025
7772339
use int not hex
barnabasbusa Jul 1, 2025
9baa3aa
fix test
barnabasbusa Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions execution_chain/rpc/common.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ from json_rpc/server import RpcServer, rpc
{.push raises: [].}

type
NodePorts* = object
discovery*: string
listener* : string
NodePorts = object
discovery: int
listener : int

NodeInfo* = object
id* : string # UInt256 hex
Expand Down Expand Up @@ -85,8 +85,8 @@ proc setupAdminRpc*(nimbus: NimbusNode, conf: NimbusConf, server: RpcServer) =
enode: $enode,
ip: $enode.address.ip,
ports: NodePorts(
discovery: $enode.address.udpPort,
listener: $enode.address.tcpPort
discovery: int(enode.address.udpPort),
listener: int(enode.address.tcpPort)
)
)

Expand Down
4 changes: 2 additions & 2 deletions tests/test_rpc.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ proc rpcMain*() =
res.name == env.conf.agentString
res.enode.startsWith("enode://")
res.ip.len > 0
res.ports.discovery.len > 0
res.ports.listener.len > 0
res.ports.discovery > 0
res.ports.listener > 0

test "admin_peers":
let peers = await client.admin_peers()
Expand Down