fix: string -> int for ports.discovery and listener#3438
Merged
jangko merged 4 commits intostatus-im:fix-importsfrom Jul 2, 2025
Merged
fix: string -> int for ports.discovery and listener#3438jangko merged 4 commits intostatus-im:fix-importsfrom
jangko merged 4 commits intostatus-im:fix-importsfrom
Conversation
Contributor
Author
|
cc: @jangko |
Contributor
|
please fix the test too res.ports.discovery.len > 0
res.ports.listener.len > 0 |
Contributor
Author
|
Fixed |
Contributor
Author
|
Peer counts now show up on dora: |
jangko
added a commit
that referenced
this pull request
Jul 2, 2025
* feat: add admin_peers and admin ns (#3431) * feat: add admin_peers and admin ns * fix redundant boolean checks and import std sections * move caps in the main block * setup admin and quit combined into one call * fix compile issues * Add export marker * Fix tests * Restore invalid request exeception in admin_addPeer * Chicken and egg * oops * fix: string -> int for ports.discovery and listener (#3438) * fix: string -> int for ports.discovery and listener * use int not hex * fix test * Add export marker * Add comments --------- Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.