Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Funding Flow Analysis Flag in Organisation #235

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

dan-tang-ssd
Copy link
Contributor

This PR is submitted to fix issue #234.

This PR contains below change:

  1. organisations table, add a boolean column "contributes_to_funding_flow"
  2. Admin Panel > Organisation CRUD, create/edit view, add checkbox for a flag to show if it contributes to funding flow analysis

Screen shot:

image

… flag to show if it contributes to funding flow analysis
Copy link
Member

@dave-mills dave-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the data entry part. Looking at it, I think we need to add it to the Institution list view as well on the same CRUD panel, so that site admins and managers can see this field without needing to click into edit mode.

After that, I think this is good to go. Thanks.

@dan-tang-ssd
Copy link
Contributor Author

Yes, it is good to show it in list view.
I have just added this feature.

image

Copy link
Member

@dave-mills dave-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good to me - thanks :)

@dan-tang-ssd dan-tang-ssd merged commit 5116bd6 into dev Nov 1, 2023
@dan-tang-ssd dan-tang-ssd deleted the add-funding-flow-flag-to-organisation branch November 1, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants