infered typehint for state machine properties 'on' and 'initial' #5217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16d17da The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could you write down (with examples) what works and what doesn't with this? Which APIs have you considered? From what I can tell, at the very least, this forbids usage of deep patterns and IDs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new flag 'scriptType' to state machine which provides different levels of typehint for states 'initial' and 'on' properties.
strictTypecan be:"strict": add type-hints and errors if types do not match, this will break some features eg spreading vars into the machine,"loose": adds type-hint but does not give errors when keys dont exist, as far as i know this keeps all compatibility,undefined: no type-hint, the default behaviour if you do not provide astrictTypeparamI wasn't too sure how states inside states should work, so i made it scoped to the nested state you are currently on.