Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a brand to Function to help distinguish resolved values from resolvers in the types #4256

Closed
wants to merge 1 commit into from
Closed

Add a brand to Function to help distinguish resolved values from resolvers in the types #4256

wants to merge 1 commit into from

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Sep 7, 2023

I'm honestly not sure if I want to land this. It feels gross but helps to avoid legitimate errors 🤷‍♂️

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: 5e7caef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Andarist
Andarist commented Sep 7, 2023
View reviewed changes
packages/core/src/types.ts
@@ -206,7 +214,7 @@ export type WithDynamicParams<
{
type: T['type'];
params?:
| T['params']
| NotAFunction<T['params']>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we decide to land this PR then this helper should be added to many more places

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e7caef:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@Andarist Andarist changed the base branch from next to main December 1, 2023 11:52
@davidkpiano
Copy link
Member

Closing per @Andarist's request

@davidkpiano davidkpiano closed this Dec 6, 2023
@Andarist Andarist mentioned this pull request Dec 15, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkpiano davidkpiano Awaiting requested review from davidkpiano

Assignees
No one assigned
Labels
needs to be revisited XState v5 post-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @davidkpiano