Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example(LLM): use @starwhale.argument feature to refactor llm finetune examples #3125

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c474ca6) 82.87% compared to head (bb1106b) 92.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3125      +/-   ##
============================================
+ Coverage     82.87%   92.04%   +9.17%     
============================================
  Files           575      139     -436     
  Lines         32125    16248   -15877     
  Branches       1873        0    -1873     
============================================
- Hits          26623    14956   -11667     
+ Misses         4674     1292    -3382     
+ Partials        828        0     -828     
Flag Coverage Δ
console ?
controller ?
standalone 92.04% <ø> (-0.08%) ⬇️
unittests 92.04% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut changed the title example(LLM): use @starwhale.argument feature to refactor llm finetune examples example(LLM): use @starwhale.argument feature to refactor llm finetune examples Jan 16, 2024
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 09edf32 into star-whale:main Jan 16, 2024
38 checks passed
@tianweidut tianweidut deleted the example/use-arguments branch January 16, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants