Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): remove column schemas dependency #3057

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 5, 2023

Description

columnSchemaMap in the RecordList is the latest version of the data
but the query or scan supports the old version of the data,
so the columnSchemaMap is meaningless except for names
we remove the column schema info from the result and other getting function calls except for parquet dump and load

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4ddef36) 82.90% compared to head (365af49) 73.89%.
Report is 2 commits behind head on main.

❗ Current head 365af49 differs from pull request most recent head 245ac6f. Consider uploading reports for the commit 245ac6f to get more accurate results

Files Patch % Lines
...arwhale/mlops/datastore/impl/WalRecordDecoder.java 77.77% 0 Missing and 4 partials ⚠️
...java/ai/starwhale/mlops/datastore/TableSchema.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3057      +/-   ##
============================================
- Coverage     82.90%   73.89%   -9.01%     
+ Complexity     3167     3160       -7     
============================================
  Files           569      431     -138     
  Lines         31541    15423   -16118     
  Branches       1850     1783      -67     
============================================
- Hits          26148    11397   -14751     
+ Misses         4574     3209    -1365     
+ Partials        819      817       -2     
Flag Coverage Δ
console ?
controller 73.89% <82.75%> (-0.03%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut merged commit 807d59f into star-whale:main Dec 20, 2023
18 checks passed
@jialeicui jialeicui deleted the optimize-ds-decode branch December 20, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants