Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): online serving failed when run in pod #3040

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Nov 28, 2023

Description

bad case: http://e2e-20231128.pre.intra.starwhale.ai/projects/1/jobs/8/tasks?active=log&taskId=116

demo: http://jialei.pre.intra.starwhale.ai/projects/1/jobs/2/servings

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft November 28, 2023 07:24
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3395e9d) 82.75% compared to head (2e3fe96) 91.79%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3040      +/-   ##
============================================
+ Coverage     82.75%   91.79%   +9.03%     
============================================
  Files           560      127     -433     
  Lines         30650    15056   -15594     
  Branches       1839        0    -1839     
============================================
- Hits          25364    13820   -11544     
+ Misses         4474     1236    -3238     
+ Partials        812        0     -812     
Flag Coverage Δ
console ?
controller ?
standalone 91.79% <100.00%> (-0.14%) ⬇️
unittests 91.79% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui added bug 🐛 Something isn't working client 🌈 labels Nov 28, 2023
@jialeicui jialeicui marked this pull request as ready for review November 28, 2023 10:32
@tianweidut tianweidut merged commit 2f714e6 into star-whale:main Nov 29, 2023
48 checks passed
@jialeicui jialeicui deleted the fix-online-serving-run branch November 29, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants