Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add domain names for object storage #3029

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Nov 24, 2023

Description

recognize regex pattern for the object store domain in the header

client part:
#3048

Test cases

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren reopened this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (73d35ef) 82.94% compared to head (31e9c97) 73.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
...mlops/storage/ksyun/StorageAccessServiceKsyun.java 0.00% 43 Missing ⚠️
...ops/storage/qcloud/StorageAccessServiceQcloud.java 0.00% 33 Missing ⚠️
...e/mlops/storage/baidu/StorageAccessServiceBos.java 0.00% 23 Missing ⚠️
...ops/storage/aliyun/StorageAccessServiceAliyun.java 29.41% 11 Missing and 1 partial ⚠️
...torage/domain/DomainAwareStorageAccessService.java 78.04% 6 Missing and 3 partials ⚠️
...mlops/storage/minio/StorageAccessServiceMinio.java 72.72% 6 Missing ⚠️
...whale/mlops/storage/s3/StorageAccessServiceS3.java 83.78% 6 Missing ⚠️
...starwhale/mlops/domain/blob/CachedBlobService.java 0.00% 3 Missing ⚠️
...ion/security/ObjectStoreDomainDetectionFilter.java 89.47% 2 Missing ⚠️
.../starwhale/mlops/storage/StorageAccessService.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3029      +/-   ##
============================================
- Coverage     82.94%   73.53%   -9.41%     
- Complexity     3168     3205      +37     
============================================
  Files           568      433     -135     
  Lines         31490    15638   -15852     
  Branches       1850     1809      -41     
============================================
- Hits          26119    11500   -14619     
+ Misses         4552     3316    -1236     
- Partials        819      822       +3     
Flag Coverage Δ
console ?
controller 73.53% <43.26%> (-0.39%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 27, 2023 09:14
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 145d209 into star-whale:main Dec 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants