Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): add resource validation for ftspace #3017

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 22, 2023

Description

  1. check whether the space belongs to project.
  2. add spaceId constraint for ft info.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (98823b4) 91.83% compared to head (8497d7b) 73.70%.

Files Patch % Lines
...ai/starwhale/mlops/domain/ft/FineTuneSpaceDao.java 50.00% 3 Missing ⚠️
...ava/ai/starwhale/mlops/api/FineTuneController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3017       +/-   ##
=============================================
- Coverage     91.83%   73.70%   -18.14%     
- Complexity        0     3142     +3142     
=============================================
  Files           126      429      +303     
  Lines         15036    15258      +222     
  Branches          0     1773     +1773     
=============================================
- Hits          13809    11246     -2563     
- Misses         1227     3204     +1977     
- Partials          0      808      +808     
Flag Coverage Δ
controller 73.70% <66.66%> (?)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit cfd26c5 into star-whale:main Nov 22, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants