Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #178 add in cache for stencils so calls aren't as excessive #179

Merged
merged 1 commit into from
Jan 7, 2020
Merged

fix: #178 add in cache for stencils so calls aren't as excessive #179

merged 1 commit into from
Jan 7, 2020

Conversation

robertleeplummerjr
Copy link
Collaborator

A cache fix.

mourner
mourner reviewed Dec 27, 2019
View reviewed changes
Copy link
Collaborator

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at a quick skim, but Travis fails for some reason — let's get it green before merging.

@dhritzkiv
Copy link
Member

Looks to be unrelated to this branch, and more-so related to the release of Node 13. Not sure how to remedy the test build yet.

Tried fixing it by pushing (to master, accidentally) a potential quick fix, but it did nothing.

@dhritzkiv dhritzkiv merged commit 8667ce0 into master Jan 7, 2020
@dhritzkiv dhritzkiv deleted the 178-cache-stencil branch January 7, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner left review comments

@dhritzkiv dhritzkiv Awaiting requested review from dhritzkiv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertleeplummerjr @dhritzkiv @mourner