Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive gl.getParameter() calls in gl.drawArrays() #178

Closed
robertleeplummerjr opened this issue Dec 26, 2019 · 3 comments
Closed

Excessive gl.getParameter() calls in gl.drawArrays() #178

robertleeplummerjr opened this issue Dec 26, 2019 · 3 comments

Comments

@robertleeplummerjr
Copy link
Collaborator

robertleeplummerjr commented Dec 26, 2019 •
edited
Loading

Profiling showed this, I tinkered with getting a solution already in place that only checks for this value when absolutely needed. It wasn't very costly, but was causing a bunch of unneeded calls into the c++ logic, and into google angle.
robertleeplummerjr added a commit that referenced this issue Dec 27, 2019
@robertleeplummerjr
fix: #178 add in cache for stencils so calls aren't as excessive
9c7ad49
@robertleeplummerjr
Copy link
Collaborator Author

Will this be released soon?

@dhritzkiv
Copy link
Member

Sorry! Thanks for the reminder. It's out as v4.4.1

@robertleeplummerjr
Copy link
Collaborator Author

Np! Ty for your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertleeplummerjr @dhritzkiv