Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolved product version #275

Merged
merged 15 commits into from
Aug 24, 2023
Merged

Use resolved product version #275

merged 15 commits into from
Aug 24, 2023

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 21, 2023

Description

Depends on stackabletech/docker-images#436

Part of : #273

🟢 OpenShift tests with custom image:

--- PASS: kuttl (1029.69s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (80.30s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (122.61s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (164.82s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (103.91s)
        --- PASS: kuttl/harness/pod_overrides_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (171.40s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (450.57s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (136.31s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev (103.35s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (204.52s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_s3-use-tls-true (278.84s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.4.0,docker.stackable.tech_sandbox_spark-k8s_3.4.0-stackable0.0.0-dev_ny-tlc-report-0.1.0 (139.17s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing. LGTM otherwise.

rust/operator-binary/src/spark_k8s_controller.rs Outdated Show resolved Hide resolved
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@razvan razvan added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 268c9cd Aug 24, 2023
30 checks passed
@bors bors bot deleted the feat/product-version branch August 24, 2023 15:35
@lfrancke
Copy link
Member

Does this change the CRD?

@razvan
Copy link
Member Author

razvan commented Aug 28, 2023

Yes. It makes the CRD more in line with the others.

@lfrancke
Copy link
Member

So, we need a release note entry?
Anything else for the next release to be aware of here?

@lfrancke
Copy link
Member

@razvan Do we need any migration steps or anything else for the next version?

@razvan
Copy link
Member Author

razvan commented Sep 22, 2023

We need an entry in the release notes that shows both the old and the new way.

@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2023-11 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants