Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PySpark the only Spark image. #436

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Make PySpark the only Spark image. #436

merged 7 commits into from
Aug 24, 2023

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 21, 2023 •
edited
Loading

Description

Kuttl tests run locally with stackabletech/spark-k8s-operator#275
Part of stackabletech/spark-k8s-operator#273

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks
Beta Give feedback

@razvan razvan self-assigned this Aug 21, 2023
@razvan razvan mentioned this pull request Aug 21, 2023
Closed
@razvan razvan mentioned this pull request Aug 22, 2023
Merged
@razvan razvan requested a review from lfrancke August 22, 2023 12:05
@maltesander maltesander self-requested a review August 24, 2023 07:55
maltesander
maltesander previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image_tools/conf.py Outdated Show resolved Hide resolved
@razvan @maltesander
Update image_tools/conf.py
8f32f5d 
Co-authored-by: Malte Sander <[email protected]>
@razvan razvan enabled auto-merge August 24, 2023 13:54
maltesander
maltesander approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 78acd8f Aug 24, 2023
14 checks passed
@razvan razvan deleted the feat/spark-with-python branch August 24, 2023 13:57
@lfrancke
Copy link
Member

Do we need to change documentation for this?
Do we need a changelog entry for this?
Migration steps?

@razvan
Copy link
Member Author

razvan commented Aug 28, 2023

The documentation has been updated in the operator.
Good question regarding migration steps: in the next release SparkApplications need to be updated anyway because of crd changes. Perhaps add them to the release notes for 23.11 ?

@lfrancke lfrancke added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release/2023-11 labels Aug 29, 2023
@lfrancke lfrancke mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@lfrancke lfrancke Awaiting requested review from lfrancke

Assignees

@razvan razvan

Labels
release/2023-11 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvan @lfrancke @maltesander