-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: relocatable package for recent CMake versions #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
force-pushed
the
topic/relocatable
branch
from
July 14, 2022 13:37
e99c1a7
to
4ffbac3
Compare
jcarpent
reviewed
Jul 14, 2022
jcarpent
reviewed
Jul 14, 2022
jcarpent
reviewed
Jul 14, 2022
Ok, I'll move that into the JRL cmakemodule |
Perfect. It will simplify future adjustments. |
nim65s
force-pushed
the
topic/relocatable
branch
from
July 14, 2022 22:16
9324f49
to
879779e
Compare
nim65s
force-pushed
the
topic/relocatable
branch
from
July 14, 2022 23:04
879779e
to
f079035
Compare
CI looks OK, except for the job requiring jrl-umi3218/jrl-cmakemodules#518 to be merged first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This enable some recent CMake features when they are available:
--as-needed
is activated.Enabling 2. allows to move around the installed project and / or its dependencies without issues, which is a required thing when we build / install on a dynamic location to ensure a proper isolation.
This PR shouldn't change anything for older systems.