Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: relocatable package for recent CMake versions #291

Merged
merged 3 commits into from
Jul 16, 2022

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Jul 14, 2022

Hi,

This enable some recent CMake features when they are available:

  1. stop linking to libpython.so as this is not necessary. And actually, it's not even a problem if this lib is not available on the build or run system. Plus it get stripped anyway when --as-needed is activated.
  2. provide only references to cmake targets instead of hardcoded absolute path in exported modules.

Enabling 2. allows to move around the installed project and / or its dependencies without issues, which is a required thing when we build / install on a dynamic location to ensure a proper isolation.

This PR shouldn't change anything for older systems.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@nim65s
Copy link
Contributor Author

nim65s commented Jul 14, 2022

Ok, I'll move that into the JRL cmakemodule

@nim65s nim65s marked this pull request as draft July 14, 2022 13:51
@jcarpent
Copy link
Contributor

jcarpent commented Jul 14, 2022

Ok, I'll move that into the JRL cmakemodule

Perfect. It will simplify future adjustments.

@nim65s nim65s marked this pull request as ready for review July 14, 2022 21:53
@nim65s
Copy link
Contributor Author

nim65s commented Jul 14, 2022

CI looks OK, except for the job requiring jrl-umi3218/jrl-cmakemodules#518 to be merged first

@jcarpent jcarpent merged commit 4f6812d into stack-of-tasks:devel Jul 16, 2022
@nim65s nim65s deleted the topic/relocatable branch July 17, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants