Skip to content

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented May 23, 2025

This came up in Home Assistant as we seek to identify un-needed constraints in Home Assistant (see home-assistant/core#145485)

@sstallion
Copy link
Owner

sstallion commented May 24, 2025

Thanks @epenet! Out of curiosity, have you tested the sensorpush_cloud integration using a newer version of urllib3? I'm not opposed to making this change, however I would appreciate it if you would verify these changes and submit a PR to bump the dependency once a release is made.

@epenet
Copy link
Contributor Author

epenet commented May 24, 2025

Thanks @epenet! Out of curiosity, have you tested the sensorpush_cloud integration using a newer version of urllib3? I'm not opposed to making this change, however I would appreciate it if you would verify these changes and submit a PR to bump the dependency once a release is made.

No I do not use this integration at all

@sstallion
Copy link
Owner

I see. Please put together and submit test that validates changing the requirement does not affect OpenAPI operation.

@epenet
Copy link
Contributor Author

epenet commented Jun 10, 2025

I see. Please put together and submit test that validates changing the requirement does not affect OpenAPI operation.

Sorry - I have no knowledge of OpenAPI

@epenet
Copy link
Contributor Author

epenet commented Jun 10, 2025

@sstallion
Copy link
Owner

Thanks! That looks good to me, I'll make a release shortly. If you would be so kind, could you update the requirements for the sensorpush_cloud integration in core for the new release? I'm out on business travel for the rest of the month and won't be able to get to it for quite some time.

@sstallion sstallion merged commit d2d6bda into sstallion:master Jun 10, 2025
sstallion pushed a commit that referenced this pull request Jun 10, 2025
@epenet epenet deleted the patch-1 branch June 11, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants