Conversation
This was referenced May 23, 2025
Closed
cdce8p
reviewed
May 23, 2025
97463d1 to
d1ec0d4
Compare
d1ec0d4 to
bbe5553
Compare
This was referenced Jun 11, 2025
cdce8p
reviewed
Jun 11, 2025
| typing-extensions>=4.14.0,<5.0 | ||
| ulid-transform==1.4.0 | ||
| urllib3>=1.26.5,<2 | ||
| urllib3>=1.26.5 |
Member
There was a problem hiding this comment.
Should we update the constraint to >=2.0 or even something newer like 2.2 or 2.4? That way we could prevent accidentally installing an old version again.
Note that it might cause issues with custom components but maybe the best way to deal with those would be to see what breaks after the release and fix the dependencies then accordingly.
Contributor
Author
There was a problem hiding this comment.
I think maybe >=2.0 is a good first step - so users have time to spot the deprecation warnings and adjust accordingly.
d903299 to
20fc69b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
urllib3 v2 was released in early 2023
https://urllib3.readthedocs.io/en/stable/v2-migration-guide.html
Needs:
Original issue #97248 was linked to botocore which has since been made compatible with urllib3 v2
See in particular boto/botocore@785d224 (enable
<2.1) and boto/botocore#3141 (enable<3)Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: