Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check and small things #41

Merged
merged 10 commits into from
Feb 2, 2025
Merged

Version check and small things #41

merged 10 commits into from
Feb 2, 2025

Conversation

FloSch62
Copy link
Member

@FloSch62 FloSch62 commented Feb 1, 2025

This PR will introduce:

  • a automatic install if clab if the user does not have clab installed ( add user to the clab_admin if yes )
  • automatic check if there is a new clab version -> automatic upgrade if yes
  • sudo is now disabled by default
  • Try to fix path problems on other OS'es
  • Settings for the drawio default theme, now with fancy nokia_modern insteand of nokia as default

@FloSch62 FloSch62 requested a review from kaelemc February 1, 2025 16:07
src/extension.ts Outdated
Comment on lines 46 to 49
/**
* Helper: Log a debug message to the output channel.
* Only logs if the outputChannel is available.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all these new functions in extension.ts. I think you should make a helpers subdir, add them in there and then import

@FloSch62 FloSch62 merged commit 979fcb4 into main Feb 2, 2025
@FloSch62 FloSch62 deleted the version_check branch February 2, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants