Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create monorepo using pnpm #52

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Create monorepo using pnpm #52

merged 3 commits into from
Jun 5, 2024

Conversation

benjreinhart
Copy link
Contributor

README.md has instructions

Essentially we now have:

├── pnpm-workspace.yaml
├── packages/
│   ├── api/
│   ├── shared/
│   └── web/
└── package.json

I moved the zod schemas and types into the shared package, as well as one util function.

@benjreinhart benjreinhart requested a review from nichochar June 5, 2024 22:52
@benjreinhart
Copy link
Contributor Author

I did not add CI or more tests in this PR, we can do that as a follow up.

Copy link
Contributor

@nichochar nichochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this. Particularly excited about the shared stuff

"compilerOptions": {
"module": "ESNext",
"skipLibCheck": true,
/* Linting */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid json !?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants