Improve vitest config and add GitHub action for lint + testing #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes I favor this too, but just haven't taken the time to set it up yet. We should do it in the not too distant future. |
nichochar
commented
May 25, 2024
| @@ -4,7 +4,7 @@ import path from 'node:path'; | |||
|
|
|||
| export const SRCBOOK_DIR = path.join(os.homedir(), '.srcbook'); | |||
|
|
|||
| const userDir = import.meta.env.VITE_NOTEBOOKS_DIR || os.homedir(); | |||
There was a problem hiding this comment.
I think we should re-add this. Idk that it should affect anything here
There was a problem hiding this comment.
we should readd this as process.env.MY_ENV_VAR.
I don't know why the vite stuff and vite namespace is used for regular operating system environment variables. The vite specific stuff is for building frontend apps that are compiled for the browser.
benjreinhart
force-pushed
the
add-github-actions
branch
from
b3cd852 to
04b65f5
Compare
nichochar
force-pushed
the
add-github-actions
branch
from
5205264 to
0a48398
Compare
benjreinhart
force-pushed
the
add-github-actions
branch
from
0a48398 to
5205264
Compare
nichochar
force-pushed
the
add-github-actions
branch
from
5205264 to
1f4ed6f
Compare
|
Closing this as its way out of date. #52 introduces monorepo, so we'll want to build on top of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the advice on the vitest getting started.
One thing I considered, but didn't do, is separate our packages into a monorepo, so
If we did this, we could leverage vitest workspaces which map nicely to npm's testing. I don't think it's a huge gain so didn't do it, but I slightly favor it in the future.