Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]:299 - uncaught exception session with id 'Not Found' after dele… #313

Merged
merged 6 commits into from
Sep 30, 2024
Merged

[FIX]:299 - uncaught exception session with id 'Not Found' after dele… #313

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bba77e
[FIX]:299 - uncaught exception session with id 'Not Found' after dele…
BeRecursive22 Sep 19, 2024
b10ed17
[FIX] - uncaught exceptions that occurs after srcbook deletion
BeRecursive22 Sep 19, 2024
35fda4f
[DEL] - previous changeset file
BeRecursive22 Sep 19, 2024
328cce4
[FIX] - linting issues
BeRecursive22 Sep 21, 2024
9e189b1
Merge branch 'main' into fix-299-session-not-found
BeRecursive22 Sep 24, 2024
ed59006
[DEL] - console log from ws
BeRecursive22 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-vans-study.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@srcbook/api': patch
---

fix(api): Handle session cleanup after srcbook deletion. Resolved an issue where deleting an srcbook would lead to an uncaught exception due to an orphaned session. The fix ensures proper cleanup of associated sessions when an srcbook is deleted, preventing the "Session with id not found" error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this message to something like "Fix uncaught exceptions that can occur after Srcbook deletion" ?

Copy link
Contributor

@benjreinhart benjreinhart Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is better placed in the PR description. Then here we can have a short message which will end up in the Changelog (which will link back to the PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjreinhart sure. But it seems like the issue is much bigger than what I anticipated previously. It looks like a race condition going on between tsserver and actual session deletion which is leading to this error

Copy link
Contributor Author

@BeRecursive22 BeRecursive22 Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjreinhart this simple order change (which I did above) of session deletion won't make it go away.

The issue, I believe is, not properly handling the errors for onSemanticDiag and onSuggestionDiag event when the session id is not found.

image

When I added extra try...catch blocks, the server didn't crash. I tried deleting multiple srcbooks and the server didn't crash.

I'll make the changes and push it.

2 changes: 1 addition & 1 deletion packages/api/server/http.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ router.options('/srcbooks/:id', cors());
router.delete('/srcbooks/:id', cors(), async (req, res) => {
const { id } = req.params;
const srcbookDir = pathToSrcbook(id);
await deleteSessionByDirname(srcbookDir);
removeSrcbook(srcbookDir);
posthog.capture({ event: 'user deleted srcbook' });
await deleteSessionByDirname(srcbookDir);
return res.json({ error: false, deleted: true });
});

Expand Down