[FIX]:299 - uncaught exception session with id 'Not Found' after dele… #313
Conversation
.changeset/six-vans-study.md
Outdated
| '@srcbook/api': patch | ||
| --- | ||
|
|
||
| fix(api): Handle session cleanup after srcbook deletion. Resolved an issue where deleting an srcbook would lead to an uncaught exception due to an orphaned session. The fix ensures proper cleanup of associated sessions when an srcbook is deleted, preventing the "Session with id not found" error. |
There was a problem hiding this comment.
Can we simplify this message to something like "Fix uncaught exceptions that can occur after Srcbook deletion" ?
There was a problem hiding this comment.
This description is better placed in the PR description. Then here we can have a short message which will end up in the Changelog (which will link back to the PR)
There was a problem hiding this comment.
@benjreinhart sure. But it seems like the issue is much bigger than what I anticipated previously. It looks like a race condition going on between tsserver and actual session deletion which is leading to this error
There was a problem hiding this comment.
@benjreinhart this simple order change (which I did above) of session deletion won't make it go away.
The issue, I believe is, not properly handling the errors for onSemanticDiag and onSuggestionDiag event when the session id is not found.
When I added extra try...catch blocks, the server didn't crash. I tried deleting multiple srcbooks and the server didn't crash.
I'll make the changes and push it.
packages/api/server/ws.mts
Outdated
| @@ -124,6 +124,7 @@ async function cellExec(payload: CellExecPayloadType) { | |||
| const session = await findSession(payload.sessionId); | |||
| const cell = findCell(session, payload.cellId); | |||
|
|
|||
| console.log('inside cellExec'); | |||
|
@nichochar can we approve the workflow or is there anything else I need to take care of? |
|
Approved, this is looking good to go! |
…ting an srcbook
fix: Handle session not found errors in TsServer event handlers