Update tsserver when deps are updated. Dont crash on missing tsserver #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nichochar
reviewed
Jul 15, 2024
| // Make sure to handle the following case here: | ||
| // | ||
| // 1. User creates a new typescript Srcbook | ||
| // 3. There is no tsserver running because it relies on the typescript package in the Srcbook's node modules, which are not yet installed. |
There was a problem hiding this comment.
Are we handling 3 ?
Btw the list goes 1, 3, 4.
There was a problem hiding this comment.
Are we handling 3 ?
Yes, that's what this code is doing. Line 258 creates a new tsserver process if there is not one running. At this point, it should work fine because this code runs after deps are installed.
| @@ -39,6 +39,11 @@ export class TsServers { | |||
| } | |||
|
|
|||
| // This is using the TypeScript dependency in the user's Srcbook. | |||
| // | |||
| // Note: If a user creates a typescript Srcbook, when it is first | |||
There was a problem hiding this comment.
Yet another reason to auto-install the deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: