Update tsserver when deps are updated. Dont crash on missing tsserver (…

…#135)

packages/api/server/ws.mts

@@ -237,8 +237,30 @@ async function depsInstall(payload: DepsInstallPayloadType) {
           source: updatedJsonSource,
           status: 'idle',
         };
-        updateSession(session, { cells: replaceCell(session, updatedCell) }, false);
-        wss.broadcast(`session:${session.id}`, 'cell:updated', { cell: updatedCell });
+
+        const updatedSession = await updateSession(
+          session,
+          { cells: replaceCell(session, updatedCell) },
+          false,
+        );
+
+        wss.broadcast(`session:${updatedSession.id}`, 'cell:updated', { cell: updatedCell });
+
+        if (updatedSession.metadata.language === 'typescript') {
+          const mustCreateTsServer = !tsservers.has(updatedSession.id);
+
+          // Make sure to handle the following case here:
+          //
+          // 1. User creates a new typescript Srcbook
+          // 3. There is no tsserver running because it relies on the typescript package in the Srcbook's node modules, which are not yet installed.
+          // 4. Now that we just installed the dependencies, we need to create a new tsserver instance.
+          const tsserver = mustCreateTsServer
+            ? createTsServer(updatedSession)
+            : tsservers.get(updatedSession.id);
+
+          // Update all code cell diagnostics now that we have new packages available.
+          requestAllDiagnostics(tsserver, updatedSession);
+        }
       },
     }),
   );

packages/api/tsserver/tsservers.mts

@@ -39,6 +39,11 @@ export class TsServers {
     }
 
     // This is using the TypeScript dependency in the user's Srcbook.
+    //
+    // Note: If a user creates a typescript Srcbook, when it is first
+    // created, the dependencies are not installed and thus this will
+    // shut down immediately. Make sure that we handle this case after
+    // package.json has finished installing its deps.
     const child = spawn('npx', ['tsserver'], {
       cwd: options.cwd,
     });
@@ -55,14 +60,13 @@ export class TsServers {
   }
 
   shutdown(id: string) {
-    const server = this.get(id);
-
-    if (!server) {
-      throw new Error(`tsserver for ${id} does not exist.`);
+    if (!this.has(id)) {
+      console.warn(`tsserver for ${id} does not exist. Skipping shutdown.`);
+      return;
     }
 
     // The server is removed from this.servers in the
     // process exit handler which covers all exit cases.
-    return server.shutdown();
+    return this.get(id).shutdown();
   }
 }