Fix http cache with authorized requests #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![lookout-staging[bot]](https://avatars.githubusercontent.com/u/15128793?s=60&v=4){kind=small}
| client.BaseURL = githubURL | ||
| client.UploadURL = githubURL | ||
| return client | ||
| } | ||
|
|
||
| func newTestPool(s suite.Suite, repoURLs []string, githubURL *url.URL, cache *cache.ValidableCache) *ClientPool { | ||
| client := newClient(githubURL, cache) | ||
| func newTestPool(s suite.Suite, repoURLs []string, githubURL *url.URL, cache *cache.ValidableCache, auth bool) *ClientPool { |
There was a problem hiding this comment.
line is 124 characters (lll)
If you have feedback about this comment, please, tell us.
smacker
approved these changes
Nov 13, 2018
|
👍 I agree it would be better to have it in a common place. But everything I could think of was too complex for such a small thing and would make the code hard to follow. |
| client.BaseURL = githubURL | ||
| client.UploadURL = githubURL | ||
| return client | ||
| } | ||
|
|
||
| func newTestPool(s suite.Suite, repoURLs []string, githubURL *url.URL, cache *cache.ValidableCache) *ClientPool { | ||
| client := newClient(githubURL, cache) | ||
| func newTestPool(s suite.Suite, repoURLs []string, githubURL *url.URL, cache *cache.ValidableCache, auth bool) *ClientPool { |
There was a problem hiding this comment.
line is 124 characters (lll)
If you have feedback about this comment, please, tell us.
Signed-off-by: Carlos Martín <[email protected]>
Signed-off-by: Carlos Martín <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #124.
The problem was that we were chaining
RoundTripperslike this:httpcache->limit->github Auth.So the cache was getting requests that did not have any auth headers added yet, but when the responses got back from github, they did have those headers.
When comparing requests with the stored responses the headers did not match, and the cache was never used.
With this PR the
RoundTrippersare now chained like this:limit->github Auth->httpcache.