Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache is bypassed when requests use authorization #124

Closed
carlosms opened this issue Aug 9, 2018 · 1 comment
Closed

Cache is bypassed when requests use authorization #124

carlosms opened this issue Aug 9, 2018 · 1 comment
Assignees

Comments

@carlosms
Copy link
Contributor

carlosms commented Aug 9, 2018

The http cache we have in use is bypassed because the request header Authorization does not match the cached response header (empty for Authorization). It is working fine when we make unauthorized requests (leaving the github env vars unset).

More exactly, this call to varyMatches returns false because of the Authorization header: https://github.com/gregjones/httpcache/blob/9cad4c3443a7200dd6400aef47183728de563a38/httpcache.go#L160

@bzz
Copy link
Contributor

bzz commented Aug 21, 2018

This can become a big deal when there are 10-100 repositories, so this can be postponed a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants