PR: Show internal errors in a QMessageBox #4040

rlaverde · 2017-01-24T15:53:35Z

This isn't ready, I implemented but the behavior isn't the expected, the QMessageBox is shown but for every single line of the traceback (because traceback_available signal is emitted for every line).

~~any ideas of how I could fix this?~~

I implemented using a QMessageBox with non modal behavior

goanpeca · 2017-01-24T16:04:54Z

I dont think a QMessageBox will do then, you could create a custom dialog with a QTableView or something that would keep growing as more messages keep coming.

rlaverde · 2017-01-25T02:10:28Z

@goanpeca Following your idea I found a way QMessageBox could be updated continuously 😄

goanpeca · 2017-01-25T03:11:20Z

👍

goanpeca · 2017-01-30T17:47:44Z

@ccordoba12 do we want rich text on the details or not? and should they be links to the actual files?

Do we want to add a submit button so users can submit that error directly?

With that is that the issue tracker can start to grow a lot, which is good and bad at the same time!

ccordoba12 · 2017-01-31T09:20:00Z

do we want rich text on the details or not? and should they be links to the actual files?

Perhaps not because that could confuse users. Besides, clickable links are already available in the internal console and that's mostly useful for us ;-)

What we could have is highlighted tracebacks, but we could leave that for another PR.

Do we want to add a submit button so users can submit that error directly?

Yep, that's really important to have ;-)

rlaverde · 2017-05-15T21:24:05Z

I added the submit button, and rebased it

ccordoba12 · 2017-05-15T22:41:07Z

spyder/widgets/sourcecode/codeeditor.py

@@ -2425,6 +2425,7 @@ def __get_current_color(self, cursor=None):

    def in_comment_or_string(self, cursor=None):
        """Is the cursor inside or next to a comment or string?"""
+        raise Exception


This is making our tests to fail. It seems an artifact of the rebase, so please remove it.

Ohhh! sorry, that was for testing, I didn't mean to commit that 🙈

ccordoba12 · 2017-05-15T22:43:39Z

@rlaverde, could we use an instance of CodeEditor to show the tracebacks? I think that would make the dialog more useful :-)

rlaverde · 2017-05-16T13:34:57Z

Could we use an instance of CodeEditor to show the tracebacks? I think that would make the dialog more useful :-)

I used a customized QMessageBox, for embedding the CodeEditor I will have to rewrite it using a Dialog and implement the layout and functionality

goanpeca · 2017-05-16T13:37:09Z

@rlaverde, could we use an instance of CodeEditor to show the tracebacks? I think that would make the dialog more useful :-)

@ccordoba12 I would say for now this is good enough and as @rlaverde he would have to basically redo all his PR for what you are asking

ccordoba12 · 2017-05-16T20:02:54Z

I would say for now this is good enough and as @rlaverde he would have to basically redo all his PR for what you are asking

Ok, no problem, let's leave things as they are.

One more thing: we need to preserve the old behavior when DEV is active. That's way more practical for us developers because traceback links are clickable in the Internal console.

rlaverde · 2017-05-31T20:41:47Z

One more thing: we need to preserve the old behavior when DEV is active. That's way more practical for us developers because traceback links are clickable in the Internal console.

Done, also when DEBUG or PYTEST is activated

…ng is activated.

ccordoba12 · 2017-06-13T01:51:34Z

spyder/plugins/console.py

+                self.msgbox_traceback = QMessageBox(
+                    QMessageBox.Critical,
+                    _('Error'),
+                    _("<b>Spyder-IDE has encountered a problem.</b>"


Remove the -IDE here.

Also add a <br> at the end.

ccordoba12 · 2017-06-13T01:53:18Z

spyder/plugins/console.py

+                      "Sorry for the inconvenience."
+                      "<b>Please tell us about this problem.</b>"
+                      "<br><br>"
+                      "You can submit this error to the github issue tracker"),


Let's change this to

You can automatically submit this error to our Github issues tracker.

Note: You need a Github account for that.

ccordoba12 · 2017-06-13T01:53:37Z

spyder/plugins/console.py

+                    parent=self)
+
+                self.submit_btn = self.msgbox_traceback.addButton(
+                        _('Submit to github'), QMessageBox.YesRole)


github -> Github

ccordoba12 · 2017-06-13T01:55:48Z

spyder/plugins/console.py

+                    _('Error'),
+                    _("<b>Spyder-IDE has encountered a problem.</b>"
+                      "Sorry for the inconvenience."
+                      "<b>Please tell us about this problem.</b>"


Let's remove this line.

ccordoba12 · 2017-06-13T01:56:33Z

I added some minor formatting comments. After that, I think this is ready!

rlaverde · 2017-06-13T21:36:11Z

I just addressed your comments, this is how it looks like:

ccordoba12 · 2017-06-15T19:48:34Z

I like it a lot, thanks!

@goanpeca, what do you say?

Fixes #1525

rlaverde added this to the v3.2 milestone Jan 24, 2017

rlaverde self-assigned this Jan 24, 2017

rlaverde force-pushed the enhancement/internal-errors-qmessage branch from 1b379f4 to 7f2ad4c Compare January 25, 2017 02:09

ccordoba12 modified the milestones: v3.2, v3.3 Feb 14, 2017

rlaverde force-pushed the enhancement/internal-errors-qmessage branch 2 times, most recently from 8ba3cca to 3d2dd80 Compare May 15, 2017 20:37

rlaverde changed the title ~~[WIP] PR: Show Internal errors in QMessage~~ PR: Show Internal errors in QMessage May 15, 2017

rlaverde requested review from goanpeca and ccordoba12 May 15, 2017 21:25

ccordoba12 reviewed May 15, 2017

View reviewed changes

rlaverde force-pushed the enhancement/internal-errors-qmessage branch from 1211dc4 to b9edcb0 Compare May 16, 2017 13:29

rlaverde force-pushed the enhancement/internal-errors-qmessage branch from 7ff4c1f to 46e2ee4 Compare May 31, 2017 20:39

rlaverde force-pushed the enhancement/internal-errors-qmessage branch 2 times, most recently from 62fba7c to 0325c46 Compare June 1, 2017 19:30

rlaverde added 5 commits June 6, 2017 11:13

Show error in QMessageBox instead of printing to internal console.

a67aef0

Change default value of show_internal_console_if_traceback to False.

c40b0f9

Add submit to github button in QMessageBox error.

98dfe7a

Remove traceback msgbox when closing it.

f93a99f

Set show_internal_console_if_traceback to True when DEV mode or testi…

a4bba99

…ng is activated.

rlaverde force-pushed the enhancement/internal-errors-qmessage branch from 0325c46 to a4bba99 Compare June 6, 2017 16:16

ccordoba12 reviewed Jun 13, 2017

View reviewed changes

Some formating changes to error QMessageBox.

8762aaa

ccordoba12 changed the title ~~PR: Show Internal errors in QMessage~~ PR: Show internal errors in a QMessageBox Jun 18, 2017

ccordoba12 merged commit 6b3d177 into spyder-ide:3.x Jun 18, 2017

ccordoba12 added a commit that referenced this pull request Jun 18, 2017

Merge from 3.x: PR #4040

cbefb71

Fixes #1525

rlaverde deleted the enhancement/internal-errors-qmessage branch June 20, 2017 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Show internal errors in a QMessageBox #4040

PR: Show internal errors in a QMessageBox #4040

rlaverde commented Jan 24, 2017 •

edited

Loading

goanpeca commented Jan 24, 2017

rlaverde commented Jan 25, 2017

goanpeca commented Jan 25, 2017

goanpeca commented Jan 30, 2017

ccordoba12 commented Jan 31, 2017

rlaverde commented May 15, 2017 •

edited

Loading

ccordoba12 May 15, 2017

rlaverde May 16, 2017 •

edited

Loading

ccordoba12 commented May 15, 2017 •

edited

Loading

rlaverde commented May 16, 2017

goanpeca commented May 16, 2017

ccordoba12 commented May 16, 2017

rlaverde commented May 31, 2017

ccordoba12 Jun 13, 2017

ccordoba12 Jun 13, 2017

ccordoba12 Jun 13, 2017

ccordoba12 Jun 13, 2017

ccordoba12 Jun 13, 2017

ccordoba12 commented Jun 13, 2017

rlaverde commented Jun 13, 2017

ccordoba12 commented Jun 15, 2017

PR: Show internal errors in a QMessageBox #4040

PR: Show internal errors in a QMessageBox #4040

Conversation

rlaverde commented Jan 24, 2017 • edited Loading

goanpeca commented Jan 24, 2017

rlaverde commented Jan 25, 2017

goanpeca commented Jan 25, 2017

goanpeca commented Jan 30, 2017

ccordoba12 commented Jan 31, 2017

rlaverde commented May 15, 2017 • edited Loading

ccordoba12 May 15, 2017

Choose a reason for hiding this comment

rlaverde May 16, 2017 • edited Loading

Choose a reason for hiding this comment

ccordoba12 commented May 15, 2017 • edited Loading

rlaverde commented May 16, 2017

goanpeca commented May 16, 2017

ccordoba12 commented May 16, 2017

rlaverde commented May 31, 2017

ccordoba12 Jun 13, 2017

Choose a reason for hiding this comment

ccordoba12 Jun 13, 2017

Choose a reason for hiding this comment

ccordoba12 Jun 13, 2017

Choose a reason for hiding this comment

ccordoba12 Jun 13, 2017

Choose a reason for hiding this comment

ccordoba12 Jun 13, 2017

Choose a reason for hiding this comment

ccordoba12 commented Jun 13, 2017

rlaverde commented Jun 13, 2017

ccordoba12 commented Jun 15, 2017

rlaverde commented Jan 24, 2017 •

edited

Loading

rlaverde commented May 15, 2017 •

edited

Loading

rlaverde May 16, 2017 •

edited

Loading

ccordoba12 commented May 15, 2017 •

edited

Loading