Skip to content

Commit

Permalink
Add submit to github button in QMessageBox error.
Browse files Browse the repository at this point in the history
  • Loading branch information
rlaverde committed May 15, 2017
1 parent 6b9eb7e commit 3d2dd80
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
6 changes: 4 additions & 2 deletions spyder/app/mainwindow.py
Original file line number Diff line number Diff line change
Expand Up @@ -2317,7 +2317,7 @@ def show_dependencies(self):
dlg.exec_()

@Slot()
def report_issue(self):
def report_issue(self, traceback=""):
if PY3:
from urllib.parse import quote
else:
Expand All @@ -2341,6 +2341,7 @@ def report_issue(self):
**Please provide any additional information below**
%s
## Version and main components
Expand All @@ -2352,7 +2353,8 @@ def report_issue(self):
```
%s
```
""" % (versions['spyder'],
""" % (traceback,
versions['spyder'],
revision,
versions['python'],
versions['qt'],
Expand Down
9 changes: 8 additions & 1 deletion spyder/plugins/console.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,16 +218,23 @@ def traceback_available(self, text):
"<b>Please tell us about this problem.</b>"
"<br><br>"
"You can submit this error to the github issue tracker"),
QMessageBox.Cancel | QMessageBox.Ok,
QMessageBox.Ok,
parent=self)

self.submit_btn = self.msgbox_traceback.addButton(
_('Submit to github'), QMessageBox.YesRole)
self.submit_btn.pressed.connect(self.press_submit_btn)

self.msgbox_traceback.setWindowModality(Qt.NonModal)
self.error_traceback = ""
self.msgbox_traceback.show()

self.error_traceback += text
self.msgbox_traceback.setDetailedText(self.error_traceback)

def press_submit_btn(self):
self.main.report_issue(self.error_traceback)
self.msgbox_traceback = None

#------ Public API ---------------------------------------------------------
@Slot()
Expand Down

0 comments on commit 3d2dd80

Please sign in to comment.