Skip to content

Conversation

@goanpeca
Copy link
Contributor

@goanpeca goanpeca commented Feb 5, 2020

@ccordoba12 I added as much options as possible with github actions.

Which versions should we test for python and which builds could we skip?

It is still pretty fast with the current setup.

@goanpeca goanpeca force-pushed the task/github-actions branch 2 times, most recently from c569ca9 to 1962c0c Compare February 6, 2020 04:18
@ccordoba12
Copy link
Member

Which versions should we test for python and which builds could we skip?

I think Python 2.7, 3.7 and 3.8 should be fine.

@goanpeca
Copy link
Contributor Author

goanpeca commented Feb 18, 2020

@ccordoba12 I suggest we use the oldest version we support and the newest, since older version are more likely to produce "issues", in that case, would that be

2.7 3.6 and 3.8?

Or are we officially supporting 3.5 ?

@goanpeca goanpeca modified the milestone: v1.10.0 Feb 18, 2020
@goanpeca goanpeca added this to the Sprint 02 - II milestone Feb 19, 2020
@goanpeca goanpeca self-assigned this Feb 19, 2020
@goanpeca goanpeca modified the milestones: Sprint 02 - II, Sprint 03 - I Mar 3, 2020
@ccordoba12 ccordoba12 modified the milestones: Sprint 03 - II, Sprint April Apr 4, 2020
@altendky altendky mentioned this pull request Jul 9, 2020
3 tasks
@goanpeca goanpeca removed their assignment Aug 22, 2020
@ccordoba12 ccordoba12 removed this from the Sprint April milestone Nov 10, 2020
@CAM-Gerlach CAM-Gerlach added this to the v1.10.0 milestone Mar 19, 2021
@CAM-Gerlach CAM-Gerlach force-pushed the task/github-actions branch from ace4dd4 to 78b2a2d Compare March 19, 2021 05:34
@CAM-Gerlach CAM-Gerlach force-pushed the task/github-actions branch from 78b2a2d to 12d6994 Compare March 19, 2021 05:46
@CAM-Gerlach
Copy link
Member

@ccordoba12 Any insight on why the CIs were disabled? It seems this project has gone essentially unmaintained for the past year, despite substantial community interest and it being in the top 200 packages on PyPI... I'll do my best to put out some fires where I can.

@CAM-Gerlach CAM-Gerlach force-pushed the task/github-actions branch 8 times, most recently from e00db7c to c7d62d2 Compare March 19, 2021 07:57
@CAM-Gerlach CAM-Gerlach force-pushed the task/github-actions branch from c7d62d2 to e320d7a Compare March 19, 2021 08:08
@CAM-Gerlach CAM-Gerlach force-pushed the task/github-actions branch from 282496c to d8f2ada Compare March 19, 2021 08:37
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Mar 19, 2021

@ccordoba12 I had to fix a number of outstanding and accumulated issues with it, update it to the latest versions of the relevant deps and fix some sub-optimal practices, rebase and clean up the commit history, update the relevant metadata and make some other improvements, but this should be all good to merge now.

Most notably, because the Qt4 packages appear to no longer be available on either pip or conda for any supported platform or channel, I had to drop those tests, though otherwise support for Qt4 itself is not officially dropped anywhere other than the CI tests. However, we should consider perhaps cutting a 1.10 release with these changes, updated metadata and the other pending PRs, and then a 2.0 release with support for Qt4 and Python 2.7 dropped (since we are no longer able to test that platform, and Python 2.7 has been EoL for over a year).

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my plethora of fixes, LGTM now.

@CAM-Gerlach
Copy link
Member

@ccordoba12 gave the okay to go ahead with this, so I'll merge this now to get our CIs working and unblock the other PRs

@CAM-Gerlach CAM-Gerlach merged commit 3efae63 into master Mar 23, 2021
@ccordoba12 ccordoba12 deleted the task/github-actions branch March 23, 2021 06:04
@dalthviz dalthviz linked an issue Aug 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNT: Stop using ci-helpers in appveyor.yml

3 participants