Core interceptors overhaul [SPR-12584]

[spring-projects-issues]

Stéphane Nicoll opened SPR-12584 and commented

Core framework interceptors essentially require the same infrastructure but does not share a lot of code.

For instance, some interceptors are qualified-based (i.e. a qualifier can be set in the annotation to customize the "handler") which brings the need for a smart cache and proper handling for AspectJ (that should clean that cache appropriately since the aspect is basically a singleton for the classloader).

This issue is a general overhaul of that infrastructure that could span other issues along the way depending of the outcome of the initial investigation.

Things to investigate:

• Some interceptor uses a qualifier on the annotation. Instead of retrieving the service every time (determineXyz) we should cache it. Transaction support has a good support now.
• ReflectionUtils#doWithMethods can return the same method several times if it's overridden. If the parent method also has the annotation we may register a proxy or a handler several times for the same bean instance! Check ReflectionUtils.getUniqueDeclaredMethods instead

---

Issue Links:

• Regression in TransactionAspectSupport.determineTransactionManager(…) [SPR-12577] #17178 Regression in TransactionAspectSupport.determineTransactionManager(…)
• MethodValidationPostProcessor using multiple (custom) validators [SPR-12563] #17164 MethodValidationPostProcessor using multiple (custom) validators

[spring-projects-issues]

Stéphane Nicoll commented

Busy describing our current support, see https://gist.github.com/snicoll/8a517c060ee072889e63

[spring-projects-issues]

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.