Regression in TransactionAspectSupport.determineTransactionManager(…) [SPR-12577]

[spring-projects-issues]

Oliver Drotbohm opened SPR-12577 and commented

If multiple PlatformTransactionManager beans are registered in an ApplicationContext, a raw @Transactional declaration should use the transaction manager bean that is determined via TransactionAspectSupport.transactionManagerBeanName. The changes for #17145 now completely ignore that property as the TransactionAttribute.getQualifier() is mistakenly compared to null. A not set qualifier will result in an empty String for annotation based TransactionAttributeSource instances so that the else clause can never be reached when using @Transactional and thus the configured bean name gets ignored. This subsequently leads to a NoUniqueBeanDefinitionException due to the by-type lookup returning two candidate beans.

---

Affects: 4.1.4

Issue Links:

• DATAJPA-657 TransactionManager reference is ignored when using Spring 4.1.4 ("is depended on by")
• @Transactional qualifier is ignored by TransactionAspectSupport if default transaction manager is set [SPR-12541] #17145 @Transactional qualifier is ignored by TransactionAspectSupport if default transaction manager is set
• Core interceptors overhaul [SPR-12584] #17185 Core interceptors overhaul
• Wrong TransactionManager selected when mixing @Transactional with and w/o qualifier [SPR-12606] #17207 Wrong TransactionManager selected when mixing @Transactional with and w/o qualifier

0 votes, 6 watchers

[spring-projects-issues]

Stéphane Nicoll commented

Proper behaviour has been restored with an explicit test about it. The repro project now works fine on all use cases.

I have also created #17185 to review that qualifier/cache logic in more details.