Cannot handle more than two @PathVariable with the route ends with ".png" [SPR-11550]

[spring-projects-issues]

oaktree opened SPR-11550 and commented

seems like there is a problem with requestMapping and PathVariable. added a gist to show the code (compare between working and not working code */

---

Affects: 4.0.1, 4.0.2

Reference URL: https://gist.github.com/oak-tree/9530666

Issue Links:

• RequestMapping with 3 PathVariable doesn't work [SPR-6741] #11407 RequestMapping with 3 PathVariable doesn't work ("duplicates")

[spring-projects-issues]

doohwan, kwak commented

it work!! in spring 4.0.2

retry again
if it is not work. attach request url & web server log

[spring-projects-issues]

oaktree commented

hey. you tried the same definition of router as i wrote in the gist? i keep getting 400

[spring-projects-issues]

oaktree commented

Request URL:http://localhost:8080/ramat-hanadiv/api/magdir/reptile/icon/similarity/frog.png

---

Request Method:GET
Status Code:400 Bad Request
Request Headersview parsed
GET /ramat-hanadiv/api/magdir/reptile/icon/similarity/frog.png HTTP/1.1
Host: localhost:8080
Connection: keep-alive
Cache-Control: no-cache
Pragma: no-cache
Content-Type: text/plain; charset=utf-8
Accept: */*
Accept-Encoding: gzip,deflate,sdch
Accept-Language: en-US,en;q=0.8,he;q=0.6

Response Headersview source

---

HTTP/1.1 400 Bad Request
Server: Apache-Coyote/1.1
Content-Type: image/png;charset=UTF-8
Content-Length: 88
Date: Fri, 14 Mar 2014 10:50:50 GMT
Connection: close

[spring-projects-issues]

oaktree commented

in the log not match. after spring security finishing filtering i get :

"12:50:53,831 DEBUG FilterChainProxy:323 - /api/magdir/reptile/icon/similarity/frog.png reached end of additional filter chain; proceeding with original chain"

[spring-projects-issues]

Brian Clozel commented

Hi oaktree
Do you have a "catch-all" mapping somewhere as well? Does this fail only when you have 3 path variables in the path?
If so, it looks a lot like #11407

[spring-projects-issues]

oaktree commented

Hey Brain,
"catch all mapping"?. you mean like control advice or something? ihave ExceptionController @ControllerAdvice but i'm actully have nothing on it.

yep. you can see my gist that is attached. when two PathVariable everything is just fine. when i add another one something doesnt work. note that if i enter the exact uri with the name of the path variables themself and the brackets i get exception ( but i pass the 400 error).

[spring-projects-issues]

oaktree commented

seems very similar to #11407. indeed.
any workaround for that?

[spring-projects-issues]

Brian Clozel commented

oaktree, by "catch-all", I meant a mapping that catches less specific requests. In your case, something like:

@Controller
@RequestMapping("/magdir")
public class MyController {

  @RequestMapping(value = "{field}/icon/{column}/{name}.jpg")  
  public void getIcon() {
    //...
  }

  @RequestMapping(value = "/{something}/**")  
  public void catchMore() {
    //...
  }

  @RequestMapping(value = "/**")  
  public void catchAll() {
    //...
  }
}

The issue mentioned here is that mapping priorities aren't computed right for mappings with 3 path variables.
So if your HTTP 400 happens because the request is mapped to another method and arguments aren't properly mapped - then this is #11407. If HTTP 400 happens for another reason, then it's not related.

Getting more logs for the org.springframework.web.servlet.mvc package should give us more info.

[spring-projects-issues]

oaktree commented

i have another mapping as in gist i.e "{field}/image/{name}.jpg" so maybe this one is related?

how can i get log for that?

[spring-projects-issues]

Brian Clozel commented

I don't think this one would match your request.
You can add the org.springframework.web.servlet.mvc package in your logger configuration (if you're using log4j, then look for log4j.properties or log4j.xml).

[spring-projects-issues]

oaktree commented

hey,
two things

1. i tried to add the next line to log4j.properties.
   log4j.logger.org.springframework.web.servlet.mvc=DEBUG
   didnt do much.

2. found out that i have catch all mapping .

   @RequestMapping("/api/**")
   public void unmappedRequest(HttpServletRequest request) {
   String uri = request.getRequestURI();
   throw new UnknownResourceException("There is no resource for path " + uri);
   }
   . remove it indeed solves the problem. so i guess its the same issue as RequestMapping with 3 PathVariable doesn't work [SPR-6741] #11407
   ..

thanks!

[spring-projects-issues]

Brian Clozel commented

Hi oaktree, thanks for working on this and confirming this issue.
I'll comment this issue when the fix will be in 4.1 SNAPSHOTS.

[spring-projects-issues]

Rossen Stoyanchev commented

Perhaps we can consider introducing a catch-all controller?