RequestMapping with 3 PathVariable doesn't work [SPR-6741]

[spring-projects-issues]

Bjorn Harvold opened SPR-6741 and commented

This RequestMapping doesn't work:

@RequestMapping(value = "/administration/user/{id}/account/{accountId}/transfer/{accounttransferId}", method = RequestMethod.GET)

This RequestMapping works:

@RequestMapping(value = "/administration/account/{accountId}/transfer/{accounttransferId}", method = RequestMethod.GET)

During startup, in both cases, Spring says that the above urls have been matched to a Class. There is only one method in the class to make sure nothing is being overridden. It seems this happens the moment I have more than 2 PathVariables defined.

---

Affects: 4.0.1

Issue Links:

• Calling a @RequestMapping annotated method with a URI template with three variables does not work [SPR-7896] #12552 Calling a @RequestMapping annotated method with a URI template with three variables does not work ("is duplicated by")
• Cannot handle more than two @PathVariable with the route ends with ".png" [SPR-11550] #16175 Cannot handle more than two @PathVariable with the route ends with ".png" ("is duplicated by")
• Determination of the best pattern match to map a handler to an URL [SPR-7589] #12245 Determination of the best pattern match to map a handler to an URL ("is duplicated by")
• AntPathMatcher.AntPatternComparator algorithm wrong for hierarchical matches [SPR-8683] #13325 AntPathMatcher.AntPatternComparator algorithm wrong for hierarchical matches
• RequestMapping path priority problem [SPR-11616] #16239 RequestMapping path priority problem

Referenced from: commits d746e3f, ce0473f, f829cd1

3 votes, 6 watchers

[spring-projects-issues]

Arjen Poutsma commented

Can you give the exact error you get, and also the startup log?

Thanks

[spring-projects-issues]

Bjorn Harvold commented

Hi Arjen,

I started creating a controller to show how the error occurs. When constructing a url that was quite unique, the 3 path variables were not a problem. The problem did occur when I had another controller that had a request mapping that was similar, but not the same, to another controller.

This works fine:
@RequestMapping("/administration/arjen/{id1}/account/{id2}/transfer/{id3}")

This does not work:
@RequestMapping(value = "/administration/user/{id1}/account/{id2}/transfer/{id3}", method = RequestMethod.GET)

Some of the request mapping urls must be clashing even though the log maps the urls to the right controller classes. I don't think we should go any further with this. If the urls are unique enough it works fine.

[spring-projects-issues]

Arjen Poutsma commented

Ok, resolving as Invalid.

[spring-projects-issues]

Keith Donald commented

This has popped up again at the forums: http://forum.springsource.org/showthread.php?t=83515

[spring-projects-issues]

Michael Piefel commented

I can confirm the issue under a side condition: When a fallback mapping exists. Take the following code:

@RequestMapping("/public/path1/{a}")
public String path(@PathVariable("a") int a) {
	log.info("Path 1: {}", a);
	return "public/home";
}
@RequestMapping("/public/path2/{a}/{b}")
public String path(@PathVariable("a") int a, @PathVariable("b") int b) {
	log.info("Path 2: {}, {}", a, b);
	return "public/home";
}
@RequestMapping("/public/path3/{a}/{b}/{c}" )
public String path(@PathVariable("a") int a, @PathVariable("b") int b, @PathVariable("c") int c) {
	log.info("Path 3: {}, {}, {}", a, b, c);
	return "public/home";
}
@RequestMapping("/public/**")
public String pathFallback() {
	log.info("FALLBACK");
	return "public/home";
}

The log says:

...RequestMappingHandlerMapping 'Mapped "{[/public/path1/{a}],methods=[],params=[],headers=[],consumes=[],produces=[],custom=[]}" onto public java.lang.String ...path(int)'
...RequestMappingHandlerMapping 'Mapped "{[/public/path2/{a}/{b}],methods=[],params=[],headers=[],consumes=[],produces=[],custom=[]}" onto public java.lang.String ...path(int,int)'
...RequestMappingHandlerMapping 'Mapped "{[/public/path3/{a}/{b}/{c}],methods=[],params=[],headers=[],consumes=[],produces=[],custom=[]}" onto public java.lang.String ...path(int,int,int)'

Calling /public/path1/42 and /public/path2/42/23 works, however /public/path3/42/23/5 calls pathFallback() instead.