Extension for CastorMarshaller - additional marshaller properties [SPR-8295]

[spring-projects-issues]

Jakub Narloch opened SPR-8295 and commented

I had been working with Werner Guttman lead of the Castor XML project on ideas for extending the Spring OXM for current Castor version.
I've prepared a patch with additional "internal" Castor properties that we would like to exposed by CastorMarshaller.
We willing to prepare a set of other enhacment in future.

I've attchet two patches one with changes made in CastorMarshaller, second with unit tests for those additional properties.
The mentioned patches contain properties specific for Castor Marshaller class used internally by Spring's CastorMarshaller.

---

Affects: 3.1 M1

Attachments:

• SpringOXMCastorMarshaller.patch (12.93 kB)
• SpringOXMCastorMarshallerTests.patch (6.55 kB)

Issue Links:

• CastorMarshaller - marshaller and unmarshaller properties. [SPR-8470] #13116 CastorMarshaller - marshaller and unmarshaller properties.
• CastorMarshaller should have suppressXMLDeclaration [SPR-7442] #12100 CastorMarshaller should have suppressXMLDeclaration ("supersedes")

Referenced from: commits dd8a9cc

1 votes, 1 watchers

[spring-projects-issues]

Arjen Poutsma commented

Patch applied. The minor changes I made:

• marshallAsDocument was renamed to marshalAsDocument, as per the Castor method
• javadoc reference to setSupressXMLDeclaration was removed, as I don't think that method called anywhere. I am aware that setSuppressXMLDeclaratian is essentially the reverse of marshalAsDocument; I just don't think it's necessary to put this in CastorMarshaller javadoc.
• the test patch was not applied, as the only thing it seemed to do was validate whether a setter method actually changed a field. I'd be more interested in tests that actually verify the behavior of the new properties. For instance, a test method which checks whether setMarshalAsDocument(false) actually gets rid of the XML declaration.