Support bean names containing '.' in PropertyOverrideConfigurer [SPR-7501]

[spring-projects-issues]

Nico De Groote opened SPR-7501 and commented

Replace the "key.indexOf(this.beanNameSeparator)" by the key.lastIndexOf()... in the processKey method.

/**
 * Process the given key as 'beanName.property' entry.
 */
	protected void processKey(ConfigurableListableBeanFactory factory, String key, String value)
			throws BeansException {

		int separatorIndex = key.indexOf(this.beanNameSeparator);
		if (separatorIndex == -1) {
			throw new BeanInitializationException("Invalid key '" + key +
					"': expected 'beanName" + this.beanNameSeparator + "property'");
		}
		String beanName = key.substring(0, separatorIndex);
		String beanProperty = key.substring(separatorIndex+1);
		this.beanNames.add(beanName);
		applyPropertyValue(factory, beanName, beanProperty, value);
		if (logger.isDebugEnabled()) {
			logger.debug("Property '" + key + "' set to value [" + value + "]");
		}
	}

---

Affects: 2.5.6

Issue Links:

• Adding trim-capability to property configurers [SPR-5839] #10509 Adding trim-capability to property configurers

[spring-projects-issues]

Juergen Hoeller commented

Since property paths may be nested, we also need to allow for dots within that part of the path. I'm afraid this will have to remain limited to non-dot bean names for that reason.

Juergen