Adding trim-capability to property configurers [SPR-5839]

[spring-projects-issues]

Laura Arhire opened SPR-5839 and commented

It would be a good option to have for the PropertyOverrideConfigurer and the PropertyPlaceholderConfigurer being able to turn on trimming of property values. This way if the user adds spaces after properties it would not break functionality

---

Reference URL: http://forum.springsource.org/showthread.php?p=246869

Issue Links:

• Add valueSeparator property to context:property-placeholder [SPR-7794] #12450 Add valueSeparator property to context:property-placeholder
• Add 'null-value' attribute to <context:property-placeholder> [SPR-13461] #18041 Add 'null-value' attribute to context:property-placeholder
• Support bean names containing '.' in PropertyOverrideConfigurer [SPR-7501] #12158 Support bean names containing '.' in PropertyOverrideConfigurer

Referenced from: commits a7ad49a

5 votes, 12 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

This issue has been resolved through a selective bulk update, as part of a larger effort to better manage unresolved issues. To qualify for the update, the issue was either created before Spring 3.0 or affects a version older than Spring 3.0 and is not a bug.

There is a good chance the request was made obsolete, or at least partly outdated, by changes in later versions of Spring including deprecations. It is also possible it didn't get enough traction or we didn't have enough time to address it. One way or another, we didn't get to it.

If you believe the issue, or some aspects of it, are still relevant and worth pursuing at present you may re-open this issue or create a new one with a more up-to-date description.

We thank you for your contributions and encourage you to become familiar with the current process of managing Spring Framework JIRA issues that has been in use for over a year.

[spring-projects-issues]

Daniil Yaroslavtsev commented

PropertyPlaceholderConfigurer (and PropertyOverrideConfigurer) still cannot trim propery values (Spring 3.2.0-RELEASE): trailing spaces or '/t' characters after property values in config file are still breaks the functionality.

[spring-projects-issues]

Samuel Araujo Teixeira commented

Remove \t and spaces (using trim)
samuelteixeiras@f9d66af

[spring-projects-issues]

Prasad Shirodkar commented

It seems Samuel Araujo Teixeira's fix was only in 3.0.X branch, and not merged into a trunk or mainline branch. The release 3.2.3 does not have this fix. Was there any particular reason this fix was not in the releases following 3.0.x? Can this ticket be expedited?

[spring-projects-issues]

Isabelle Guimiot commented

+1
This improvement would be really helpful !

[spring-projects-issues]

Juergen Hoeller commented

This has finally been added as trim-values flag on <context:property-placeholder> a.k.a setTrimValues(boolean) on the placeholder configurer classes. Sorry that it took so long...

Juergen

[thechosenone124]

Was this functionality ever added to PropertyOverrideConfigurer? There are no trim functions among the methods.