Allow configuring view resolution through the MVC Java config and the MVC Namespace [SPR-7093]

[spring-projects-issues]

Oliver Drotbohm opened SPR-7093 and commented

It would be cool to have ViewResolvers like InternalResourceViewResolver available to be declared via the MVC namespace. I imagine something similar to the <mvc:interceptors /> element already present, where you provide either predefined subelements or plain bean definitions. Although one could argue that the benefit is rather limited it completes the picture of configurable MVC components nicely, especially as the order can then be determined explicitly.

Maybe one can also ease the use of ContentNegotiatingViewResolver which is not the most approachable class in regards of configuration currently ;).

I'll probably provide a draft implementation as patch in a few days.

---

Sub-tasks:

• Update documentation with MVC config view resolution examples [SPR-11989] #16605 Update documentation with MVC config view resolution examples

Issue Links:

• Allow configuring view resolution through the MVC Java config [SPR-9533] #14167 Allow configuring view resolution through the MVC Java config ("is duplicated by")
• Add mvc:annotation-driven Tiles Configuration [SPR-6556] #11222 Add mvc:annotation-driven Tiles Configuration ("supersedes")

Referenced from: commits dfcc1d7, 52f1be7, 10a4c2c, a26b1ef, 5e1a5c8, f54cee4, 92402e7, 5bc7937, cc7e8f5

2 votes, 7 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

How about something like this?

Without a ContentNegotiatingViewResolver:

<mvc:view-resolvers>
  <mvc:jsp prefix="/WEB-INF/" suffix=".jsp" />
  <mvc:tiles definitions="/WEB-INF/**/views.xml" />
  <mvc:freemarker />
  <mvc:bean-name />
</mvc:view-resolvers>

With ContentNegotiatingViewResolver:

<mvc:content-negotiating-resolver useNotAcceptableStatusCode="true">
    <mvc:view-resolvers>
        <bean ref="thymeLeafViewResolver />
        <mvc:bean-name />
    </mvc:view-resolvers>
    <mvc:default-views>
        <bean ref="jsonView" />
        <bean ref="marshallingView" />
    </mvc:default-views>    
</mvc:content-negotiating-resolver>

Note that the various other content negotiation properties on ContentNegotiatingViewResolver have been deprecated (as part of #13057) in favor of providing a single ContentNeogitationManager property. That will be configurable more centrally via mvc:annotation-driven but it may make sense to make it available under the content-negotiating-view-resolver element as well.

[spring-projects-issues]

Oliver Drotbohm commented

Looks good to me.

[spring-projects-issues]

Sivaprasad Valluru commented

Rossen,

I started Working on this issue.

Wrote the code for a bean definition parser which will make the following configuration to work :

mvc:view-resolvers
<mvc:jsp prefix="/WEB-INF/" suffix=".jsp" />
<mvc:tiles definitions="/WEB-INF/**/views.xml" />
</mvc:view-resolvers>

I didnt understand what you meant by <mvc:bean-name /> . How is it supposed to work?
When u configure <mvc:bean-name /> which bean should be registered in the back ground?
Can u please elaborate on it?

[spring-projects-issues]

Rossen Stoyanchev commented

I started Working on this issue.

great

When u configure <mvc:bean-name /> which bean should be registered in the back ground?

That would be BeanNameViewResolver.

[spring-projects-issues]

Sivaprasad Valluru commented

Rossen,

I raised a pull request for this issue.
Please visit the following url : #348

Please let me know your comments.
Please let me know if i am missing any thing.

Siva

[spring-projects-issues]

Sivaprasad Valluru commented

Rossen,

As per your advice, i have added test cases in my pull request.
Please visit the following Url :#348

Let me know if i am missing something

Siva

[spring-projects-issues]

Sébastien Deleuze commented

Thanks for your contribution and for signing the CLA Sivaprasad Valluru.

The implementation is available in the https://github.com/sdeleuze/spring-framework/tree/SPR-7093 branch, and will be merged in master soon. Any feedbacks welcome ...

[spring-projects-issues]

Sébastien Deleuze commented

Pull request #572 submitted.