Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,13 @@ public void stop() {
@Override
public int getPort() {
Connector[] connectors = this.server.getConnectors();
Integer localPort = -1;
for (Connector connector : connectors) {
// Probably only one...
return getLocalPort(connector);
localPort = getLocalPort(connector);
break;
}
return 0;
return (localPort > 0) ? localPort : -1;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public int getPort() {
return -1;
}
}
return 0;
return -1;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ public int getPort() {
if (connector != null) {
return connector.getLocalPort();
}
return 0;
return -1;
}

private String getContextPath() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public void stop() throws WebServerException {
public int getPort() {
List<Port> ports = getActualPorts();
if (ports.isEmpty()) {
return 0;
return -1;
}
return ports.get(0).getNumber();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,16 @@ void specificPort() throws Exception {
assertThat(this.webServer.getPort()).isEqualTo(specificPort);
}

@Test
void portIsMinusOneWhenConnectionIsClosed() {
AbstractReactiveWebServerFactory factory = getFactory();
this.webServer = factory.getWebServer(new EchoHandler());
this.webServer.start();
assertThat(this.webServer.getPort()).isGreaterThan(0);
this.webServer.stop();
assertThat(this.webServer.getPort()).isEqualTo(-1);
}

@Test
void basicSslFromClassPath() {
testBasicSslWithKeyStore("classpath:test.jks", "password");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ void emptyServerWhenPortIsMinusOne() {
factory.setPort(-1);
this.webServer = factory.getWebServer(exampleServletRegistration());
this.webServer.start();
assertThat(this.webServer.getPort()).isLessThan(0); // Jetty is -2
assertThat(this.webServer.getPort()).isEqualTo(-1);
}

@Test
Expand Down Expand Up @@ -300,6 +300,16 @@ void loadOnStartAfterContextIsInitialized() {
assertThat(servlet.getInitCount()).isEqualTo(1);
}

@Test
void portIsMinusOneWhenConnectionIsClosed() {
AbstractServletWebServerFactory factory = getFactory();
this.webServer = factory.getWebServer();
this.webServer.start();
assertThat(this.webServer.getPort()).isGreaterThan(0);
this.webServer.stop();
assertThat(this.webServer.getPort()).isEqualTo(-1);
}

@Test
void specificPort() throws Exception {
AbstractServletWebServerFactory factory = getFactory();
Expand Down