WebServer implementations should return -1 if not listening on a port #24606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface org.springframework.boot.web.server.WebServer defines that getPort() returns -1 if the server isn't listening on a port. This commit changes the implementations of the interface accordingly. See spring-projectsgh-24540
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Jan 6, 2021
Update `WebServer` implementations to return -1 from `getPort()` if the server isn't listening on a port. This aligns the implementations with the interface Javadoc. See gh-24606
philwebb
added a commit
that referenced
this pull request
Jan 6, 2021
|
Thanks very much for the compressive PR @spartusch. This has been merged to 2.3.x, 2.4.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface
org.springframework.boot.web.server.WebServerdefines thatgetPort()returns-1if the server isn't listening on a port. But the current implementations of the interface return 0 instead. This changes the implementations to return -1.Please note: Jetty itself does return -2 as the local port after the connection has been closed. Therefore in its implementation getPort() maps all local ports <= 0 to -1 to match the method's contract.
See #24540