Rename max-http-post-size server property

[rhamedy]

Fixes #18521

@wilkinsona here is a summary of changes

• Updated ServerProperties.java to deprecate the max-http-post-size for both tomcat and jersey and introduced replacements max-http-form-post-size
• Updated the ServerPropertiesTests.java to add new tests for tomcatMaxHttpFormPostSizeMatchesConnectorDefault
• Updated the ServerPropertiesTests.java to add new test for jettyMaxHttpFormPostSizeMatchesDefault (this test is 99% same as jettyMaxHttpPostSizeMatchesDefault, what do you think about refactoring common code?)
• Updated the TomcatWebServerFactoryCustomizer.java for the new property maxHttpFormPostSize and added tests for it inTomcatWebServerFactoryCustomizerTests.java

@Test
public void customMaxHttpPostSize() {
	bind("server.tomcat.max-http-post-size=10000");
	bind("server.tomcat.max-http-form-post-size=10000");
	customizeAndRunServer(
		(server) -> assertThat(server.getTomcat().getConnector().getMaxPostSize()).isEqualTo(10000));
}

without bind("server.tomcat.max-http-form-post-size=10000"); this test and customDisableMaxHttpPostSize fails. This is due to addition of the new property but, when binding both as shown above then it passes. Not sure if it's because both these props point to the same property in connector or because I messed up the mapping in customizers.

• Updated the JettyWebServerFactoryCustomizer for the new property

Not sure if I missed out anything that needs to be updated. I would appreciate a review and will squash my commits once all the code review comments are addressed.

Thanks.

[wilkinsona]

Thanks very much for the pull request, @rhamedy. Please let us know if you have the time to make the requested changes in the next few days. No problem at all if you don't, we can make the changes in a polishing commit as part of merging your changes.

[rhamedy]

Hi @wilkinsona
I appreciate the clear and very detailed review comments. I believe I have addressed them all, please let me know if any more changes need to be made. I have not yet squashed my commits in order to allow requested changes to be reviewed easily. As soon as you approve the changes then I would squash my commits 👍 I got plenty of time this week 😄

Out of curiosity, is this deprecation any different from other deprecations? I notice that in ServerProperties.java the max-http-header-size does not only have the @DeprecatedConfigurationProperty but, also the @Deprecated. We have not added @Deprecated in the old property getters and setters however, we did change them to use the new field, I wonder if because of this we don't need to mark them as @Deprecated 🤔

Thanks for the help.

[wilkinsona]

Things look good now. Thank you for the updates.

Let's mark the old getters and setters as @Deprecated as well, for consistency if nothing else. Let me know if you have time to do that and to squash your commits. If not, we can take care of it when merging.

[rhamedy]

Hi @wilkinsona
I have applied the requested changes and squashed my commit. It's all yours. Thank you for your help 🙂

[philwebb]

Thanks a lot @rhamedy! This is now in 2.1.x and master.