It is unclear that server.tomcat.max-http-post-size and server.jetty.max-http-post-size only apply to POSTed form content

[fg8dgrdh]

The documentation describes the following:

server.tomcat.max-http-post-size=2MB # Maximum size of the HTTP post content.

However this setting only affects post requests with FORM content, not all post requests. This can lead to confusion for myself and others (as per stackoverflow questions). A more precise description would be helpful, such as:

server.tomcat.max-http-post-size=2MB # Maximum size of the FORM content in an HTTP post request. Non-FORM post requests are unaffected by this property.

[sbrannen]

@fg8dgrdh, this is the issue tracker for the core Spring Framework.

For Spring Boot, please use the following issue tracker: https://github.com/spring-projects/spring-boot/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Or perhaps @snicoll or @philwebb can transfer this issue.

[snicoll]

Or perhaps @snicoll or @philwebb can transfer this issue.

Yes we can but please give us a bit of time to act on it before closing.

[rhamedy]

@snicoll can I make a PR for this?

[snicoll]

Thanks for the offer. The issue has been triaged and isn't assigned at the moment so feel free to do it

[rhamedy]

Updated the Javadoc in the ServerProperties.java, not sure if there is anything else that needs to be done.

[wilkinsona]

We have a similar problem with Jetty. The property, server.jetty.max-http-post-size, is described as "Maximum size of the HTTP post or put content" but it maps onto setMaxFormContentSize and is specific to POSTed form content. As far as I can tell, content sent as a PUT is not affected.

Undertow is also affected but the problem is different. The property, server.undertow.max-http-post-size, is described as "Maximum size of the HTTP post content. When the value is -1, the default, the size is unlimited". It maps onto Undertow.MAX_ENTITY_SIZE which isn't limited to form content but also isn't limited to POST requests. The property would be better named something like server.undertow.max-http-entity-size.

Given that we need to deprecate server.undertow.max-http-post-size and provide a replacement, I wonder if we should do similar for server.jetty.max-http-post-size and server.tomcat.max-http-post-size. max-http-form-post-size would perhaps be a more accurate name.