Allow Jetty's threadpool to be configured via properties #17871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
ehab-qadah
reviewed
Aug 15, 2019
| /** | ||
| * Maximum amount of threads. | ||
| */ | ||
| private Integer maxThreads = 200; |
There was a problem hiding this comment.
would not be better to set the maximum number of threads based on the number of available cores?
There was a problem hiding this comment.
The values here are the default of the embedded servers and we don't deviate from that unless necessary. If you want to pursue this idea, I'd raise an issue against the Jetty project.
mbhave
added
type: enhancement
mbhave
pushed a commit
that referenced
this pull request
Aug 16, 2019
mbhave
added a commit
that referenced
this pull request
Aug 16, 2019
mbhave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to GitHub issue #5314 which allows for configuration of Jetty's default thread pool,
QueuedThreadPool, via the environment. Updated server properties are to include maxThreads, minThreads, and idleTimeout.