Improve LDAP auto-configuration conditions #13143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
At present, auto-configuration of `LdapContextSource` is conditional on presence of `ContextSource` bean. However, there are valid use cases which require multiple `ContextSource` bean, for instance `PooledContextSource`. With the current arrangement, the auto-configuration of `LdapContextSource` will back off if user provides `PooledContextSource` bean, while it would still be reasonable to reuse auto-configured `LdapContextSource`. This commit improves `LdapContextSource` factory method return value and condition to back off only if users actually provide `LdapContextSource` bean themselves.
vpavic
force-pushed
the
improve-ldap-condition
branch
from
25d4e76 to
29528b7
Compare
snicoll
pushed a commit
that referenced
this pull request
May 11, 2018
At present, auto-configuration of `LdapContextSource` is conditional on presence of a `ContextSource` bean. However, there are valid use cases which require multiple `ContextSource` bean, for instance `PooledContextSource`. With the current arrangement, the auto-configuration of `LdapContextSource` will back off if user provides a `PooledContextSource` bean, while it would still be reasonable to reuse the auto-configured `LdapContextSource`. This commit improves `LdapContextSource` factory method return value and condition to back off only if users actually provide a `LdapContextSource` bean themselves. See gh-13143
snicoll
added a commit
that referenced
this pull request
May 11, 2018
* pr/13143: Polish "Improve LDAP auto-configuration conditions" Improve LDAP auto-configuration conditions
snicoll
added
type: task
|
Thanks Vedran! I've polished the PR in 8e9a873. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, auto-configuration of
LdapContextSourceis conditional on presence ofContextSourcebean. However, there are valid use cases which require multipleContextSourcebean, for instancePooledContextSource. With the current arrangement, the auto-configuration ofLdapContextSourcewill back off if user providesPooledContextSourcebean, while it would still be reasonable to reuse auto-configuredLdapContextSource.This PR improves
LdapContextSourcefactory method return value and condition to back off only if users actually provideLdapContextSourcebean themselves.With this change in place, users can provide
PooledContextSourcebean and reuse auto-configuredLdapContextSource.PooledContextSourcebean should then be marked as@Primaryto ensure it is injected in auto-configuredLdapTemplate.