Improve LDAP auto-configuration #13136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-configuration of LDAP's `LdapTemplate` is currently a part of `LdapDataAutoConfiguration` which is conditional of presence of `LdapRepository` (i.e. Spring Data LDAP). This arrangement isn't ideal since the `LdapTemplate` is a part of Spring LDAP project, and therefore should not be tied to Spring Data LDAP. This commit improves and simplifies LDAP auto-configuration by moving `LdapTemplate` configuration to `LdapAutoConfiguration`. Consequently, `LdapDataAutoConfiguration` is not needed anymore and is removed.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
approved these changes
May 11, 2018
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
May 11, 2018
Auto-configuration of LDAP's `LdapTemplate` is currently a part of `LdapDataAutoConfiguration` which is conditional of presence of `LdapRepository` (i.e. Spring Data LDAP). This arrangement isn't ideal since the `LdapTemplate` is a part of Spring LDAP project, and therefore should not be tied to Spring Data LDAP. This commit improves and simplifies LDAP auto-configuration by moving `LdapTemplate` configuration to `LdapAutoConfiguration`. Consequently, `LdapDataAutoConfiguration` is not needed anymore and is removed. See gh-13136
snicoll
added a commit
that referenced
this pull request
May 11, 2018
* pr/13136: Polish "Improve LDAP auto-configuration" Improve LDAP auto-configuration
|
Nice one, thanks @vpavic! |
filiphr
added a commit
to flowable/flowable-engine
that referenced
this pull request
Aug 14, 2019
…m tests Before 2.1.0 the LdapHealthIndicator was not created due to the missing LdapOperations. However since 2.1 the LdapOperations bean creation was moved into the LdapAutoConfiguration (see spring-projects/spring-boot#13136) which lead to the LdapHealthIndicator being created and thus the FlowableIdmApplicationSecurityTest was failing due to the ldap user and password being null. See spring-projects/spring-boot#17861 for the problem in Spring Boot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-configuration of LDAP's
LdapTemplateis currently a part ofLdapDataAutoConfigurationwhich is conditional of presence ofLdapRepository(i.e. Spring Data LDAP). This arrangement isn't ideal (and doesn't make much sense) since theLdapTemplateis a part of Spring LDAP project, and therefore should not be tied to Spring Data LDAP.This PR improves and simplifies LDAP auto-configuration by moving
LdapTemplateconfiguration toLdapAutoConfiguration. Consequently,LdapDataAutoConfigurationis not needed anymore and is removed.