Skip to content

Remove destroyMethod attribute in @Bean for MeterRegistry #12725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove destroyMethod attribute in @Bean for MeterRegistry #12725

wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Apr 3, 2018

As MeterRegistry is AutoCloseable and stop() is called in close(), destroyMethod attributes can be removed.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2018
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 3, 2018
@snicoll snicoll self-assigned this Apr 3, 2018
@snicoll snicoll modified the milestones: 2.0.x, 2.0.1 Apr 3, 2018
@snicoll
Copy link
Member

snicoll commented Apr 3, 2018

Thanks again @izeye!

@snicoll snicoll closed this in 4ab4398 Apr 3, 2018
snicoll added a commit that referenced this pull request Apr 3, 2018
@snicoll
Merge pull request #12725 from izeye:destroy-method
958f3d5 
* pr/12725:
  Remove destroyMethod attribute in @bean for MeterRegistry
@izeye izeye deleted the destroy-method branch April 3, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

2.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@izeye @snicoll @spring-projects-issues