Skip to content

Commit 958f3d5

Browse files
committed
Merge pull request #12725 from izeye:destroy-method
* pr/12725: Remove destroyMethod attribute in @bean for MeterRegistry
2 parents 3568019 + 4ab4398 commit 958f3d5

File tree

10 files changed

+10
-10
lines changed

10 files changed

+10
-10
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/atlas/AtlasMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public String get(String k) {
142142
@Import(BaseConfiguration.class)
143143
static class CustomRegistryConfiguration {
144144

145-
@Bean(destroyMethod = "stop")
145+
@Bean
146146
public AtlasMeterRegistry customRegistry(AtlasConfig config, Clock clock) {
147147
return new AtlasMeterRegistry(config, clock);
148148
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/datadog/DatadogMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public String get(String k) {
154154
@Import(BaseConfiguration.class)
155155
static class CustomRegistryConfiguration {
156156

157-
@Bean(destroyMethod = "stop")
157+
@Bean
158158
public DatadogMeterRegistry customRegistry(DatadogConfig config, Clock clock) {
159159
return new DatadogMeterRegistry(config, clock);
160160
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/ganglia/GangliaMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public String get(String k) {
142142
@Import(BaseConfiguration.class)
143143
static class CustomRegistryConfiguration {
144144

145-
@Bean(destroyMethod = "stop")
145+
@Bean
146146
public GangliaMeterRegistry customRegistry(GangliaConfig config, Clock clock) {
147147
return new GangliaMeterRegistry(config, clock);
148148
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/graphite/GraphiteMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public String get(String k) {
145145
@Import(BaseConfiguration.class)
146146
static class CustomRegistryConfiguration {
147147

148-
@Bean(destroyMethod = "stop")
148+
@Bean
149149
public GraphiteMeterRegistry customRegistry(GraphiteConfig config, Clock clock) {
150150
return new GraphiteMeterRegistry(config, clock);
151151
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/influx/InfluxMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public String get(String k) {
142142
@Import(BaseConfiguration.class)
143143
static class CustomRegistryConfiguration {
144144

145-
@Bean(destroyMethod = "stop")
145+
@Bean
146146
public InfluxMeterRegistry customRegistry(InfluxConfig config, Clock clock) {
147147
return new InfluxMeterRegistry(config, clock);
148148
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/jmx/JmxMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ public String get(String k) {
158158
@Import(BaseConfiguration.class)
159159
static class CustomRegistryConfiguration {
160160

161-
@Bean(destroyMethod = "stop")
161+
@Bean
162162
public JmxMeterRegistry customRegistry(JmxConfig config, Clock clock) {
163163
return new JmxMeterRegistry(config, clock);
164164
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/newrelic/NewRelicMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public String get(String k) {
172172
@Import(BaseConfiguration.class)
173173
static class CustomRegistryConfiguration {
174174

175-
@Bean(destroyMethod = "stop")
175+
@Bean
176176
public NewRelicMeterRegistry customRegistry(NewRelicConfig config, Clock clock) {
177177
return new NewRelicMeterRegistry(config, clock);
178178
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/signalfx/SignalFxMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public String get(String k) {
164164
@Import(BaseConfiguration.class)
165165
static class CustomRegistryConfiguration {
166166

167-
@Bean(destroyMethod = "stop")
167+
@Bean
168168
public SignalFxMeterRegistry customRegistry(SignalFxConfig config, Clock clock) {
169169
return new SignalFxMeterRegistry(config, clock);
170170
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/statsd/StatsdMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public String get(String k) {
160160
@Import(BaseConfiguration.class)
161161
static class CustomRegistryConfiguration {
162162

163-
@Bean(destroyMethod = "stop")
163+
@Bean
164164
public StatsdMeterRegistry customRegistry(StatsdConfig config, Clock clock) {
165165
return new StatsdMeterRegistry(config, clock);
166166
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsExportAutoConfigurationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public String uri() {
146146
@Import(BaseConfiguration.class)
147147
static class CustomRegistryConfiguration {
148148

149-
@Bean(destroyMethod = "stop")
149+
@Bean
150150
public WavefrontMeterRegistry customRegistry(WavefrontConfig config,
151151
Clock clock) {
152152
return new WavefrontMeterRegistry(config, clock);

0 commit comments

Comments
 (0)