Skip to content

Add docker-api starter on spring-boot-starters' README #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add docker-api starter on spring-boot-starters' README #12605

wants to merge 3 commits into from

Conversation

@jliuold
Copy link

@jliuold jliuold commented Mar 23, 2018

Add docker-java starter on spring-boot-starters readme.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 23, 2018
@bclozel
Copy link
Member

bclozel commented Mar 23, 2018

@jliu666 I've created a few issues on your starter. Could you take a look at those first?

@jliuold
Copy link
Author

jliuold commented Mar 23, 2018

@bclozel OK! Thank you.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Mar 23, 2018
@jliuold
Copy link
Author

jliuold commented Mar 27, 2018

@bclozel I have answered some questions. Could you give me more suggestions?

@jliuold jliuold changed the title Add docker-java starter on spring-boot-starters' README Add docker-api starter on spring-boot-starters' README Mar 27, 2018
@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Mar 27, 2018
@bclozel
Copy link
Member

bclozel commented Mar 27, 2018

I've opened jliuold/docker-api-spring-boot#1, jliuold/docker-api-spring-boot#2 and jliuold/docker-api-spring-boot#3.

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Mar 27, 2018
@jliuold
Copy link
Author

jliuold commented Mar 31, 2018

OK! Thank you very much!
Now those issues may be resolved now.

@bclozel bclozel self-requested a review April 5, 2018 08:59
@bclozel bclozel closed this in 34986ed Apr 5, 2018
bclozel added a commit that referenced this pull request Apr 5, 2018
@bclozel
Merge pull request #12605 from jliu666:master
b23befc 
* pr/12605:
  Add docker-api starter to 3rd party list
@bclozel bclozel added type: task A general task and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Apr 5, 2018
@bclozel bclozel added this to the 2.0.1 milestone Apr 5, 2018
@jliuold
Copy link
Author

jliuold commented Apr 6, 2018 •
edited
Loading

@bclozel
Hello. This is my first pull request. Could you please tell me the status of the pull request? I don't know the label type:task's meaning.

@bclozel
Copy link
Member

bclozel commented Apr 6, 2018 •
edited
Loading

It's been merged with b23befc (I polished a bit your commit). It's live already.
Thanks!

The type:task label is just a way for the team to categorize issues - in this case, this wasn't a bug nor an enhancement request, but rather something that needed to be done, hence "task".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bclozel bclozel Awaiting requested review from bclozel

Assignees

No one assigned

Labels

type: task A general task

Projects

None yet

Milestone

2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@jliuold @bclozel @snicoll @spring-projects-issues @jliu666